Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed event listener memory leak #35

Merged
merged 1 commit into from
Feb 14, 2021
Merged

Fixed event listener memory leak #35

merged 1 commit into from
Feb 14, 2021

Conversation

jacobdoran
Copy link
Contributor

Event listeners should be removed when plugin is destroyed.

Fixed event listener memory leak
8359016 
Event listeners should be removed when plugin is destroyed.
@dmonad
Copy link
Member

dmonad commented Feb 14, 2021

Right, thank you!

@dmonad dmonad merged commit 914a6d0 into yjs:master Feb 14, 2021
@tommoor
Copy link
Contributor

tommoor commented May 20, 2021

qq @jacobdoran – do you remember if you saw any odd behavior from this bug or was it purely a memory leak fix?

@jacobdoran
Copy link
Contributor Author

qq @jacobdoran – do you remember if you saw any odd behavior from this bug or was it purely a memory leak fix?

Behavior was fine but it was showing errors in the console log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobdoran @dmonad @tommoor